search

liamaharon / handy-handbook-tool

Google Chrome extension that improves the user experience of the University of Melbourne handbook
https://chrome.google.com/webstore/detail/handy-handbook-tool/kgjgnfjefohopigifkpplgjcmobgmoch
MIT License
4 stars 3 forks source link

Width of sidebar different with extension #1

Open banool opened 7 years ago

banool commented 7 years ago

I see that with the extension, there is less space for the sidebar. I'm not sure if this is a good choice or not (it probably is, because the sidebar is sooooo big in the original page, though imo I like the original sidebar width), but there is a lot of wasted white space between the sidebar and the content when using the extension. I wonder if the div for the content could be made wider, or instead the sidebar could be returned to its original width.

Without extension: Without extension With extension: With extension

liamaharon commented 7 years ago

The width was set like this in preparation to widen the content div, as you suggested. This turned out not to be a trivial change, so I left it as is and worked on more important features. I chose to leave it this way for now for two reasons

  1. Make it easier to widen the content div later on
  2. When the sidebar is set to scroll with the user it loses its right justification and ends up looking like this hht which I don't want to spend time fixing if I'm going to widen the content div later anyway

For now will use this issue to track progress widening the content div, thanks for initiating discussion :smile: