search

liamappelbe / fftea

A simple and efficient FFT implementation for Dart
Apache License 2.0
66 stars 1 forks source link

Propose to merge with SciDart #24

Open polotto opened 2 years ago

polotto commented 2 years ago

Hello! Congratulations for this great project. I'm glad that you mentioned SciDart inside of your benchmarks. I quit the Radix implementation because of complexity and the shortly time. I'm just wondering here: What you think to bring this implementation to be part of SciDart? For me make sense because SciDart was born exactly with the propose to merge all the Dart Scientific stuff.

liamappelbe commented 2 years ago

Hi Angelo, Fftea is a personal project, and I like having sole control over it, so I don't really want to merge it with SciDart. But you're certainly welcome to import it into SciDart and either re-export it as-is, or wrap it in your own API to make it consistent with the rest of your API (and avoid breaking API changes). I'd be happy to help you integrate it into SciDart, or fix any bugs you find, or provide utils that make the integration easier, but I'd like to keep it as a separate project.

certainlyWrong commented 2 years ago

@polotto Remember that the implementation of the MFCCs extraction algorithm uses the amazing FFTea. My implementation of the MFCCs extraction algorithm is based on this one. I believe that Dart has incredible potential for science and I am happy for your initiative.

polotto commented 2 years ago

@liamappelbe You project already support all the platforms, priority number one on SciDart. So, I'll first import your package and create a interface layer to make consistent with all the other SciDart APIs. This way, while you keep the FFTEA project, I'll keep the SciDart updated. If in the future you depreciate this project, then I'll incorporate on SciDart. Thank you for the quick response!

polotto commented 2 years ago

@certainlyWrong This is a good start point for me!