search

liamcain / obsidian-creases

👕 Tools for effectively folding markdown sections in Obsidian
MIT License
228 stars 8 forks source link

bug #21 fix #35

Closed nicolasmarc1 closed 2 years ago

nicolasmarc1 commented 2 years ago

Hi!

This is a bug fix for bug breaking block reference · Issue #21 · liamcain/obsidian-creases like we said in the issue there was a need for consistency between the 2 functions so i refactored some logic in a new function getFoldTargetPosition to get consistent behavior (taking into account blockIDs) between toggleCrease and creaseCurrentFolds.

This is my first contribution to an open source/github repo, so I hope everything is okay?

Fixes #21

Thanks!

nicolasmarc1 commented 2 years ago

wait so i think i also included package-lock.json and yarn lock with the commit, i tried to modify my last commit by unstaging them and to repush but it also seem to have accidently also included the commit before that and idk how to fix this, i'm sorry

nicolasmarc1 commented 2 years ago

Okay never mind, whatever i did the second time to correct it, also committed the wrong thing, i'm redoing the pr and fork from scratch