liamcain / obsidian-things-logbook

Sync your Things 3 Logbook with Obsidian
MIT License
120 stars 22 forks source link

Duplicate logging #11

Open matpatterson opened 3 years ago

matpatterson commented 3 years ago
Screen Shot 2021-04-23 at 8 16 53 am Screen Shot 2021-04-23 at 8 18 14 am

The same completed items are pulled in multiple times for me. Any troubleshooting suggestions?

liamcain commented 3 years ago

@matpatterson, why does your heading say ## COMPLETED and the section setting has ## Completed? Could you try changing the text to match exactly and see if the issue persists?

I'll see if I can reproduce the issue locally.

matpatterson commented 3 years ago

That’s just CSS changing the presentation, the file itself matches the case

On 28 Apr 2021, at 12:19 pm, Liam Cain @.***> wrote:

 @matpatterson, why does your heading say ## COMPLETED and the section setting has ## Completed? Could you try changing the text to match exactly and see if the issue persists?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

liamcain commented 3 years ago

That’s just CSS changing the presentation, the file itself matches the case

Aah, okay. We can rule that out then.


I was able to reproduce the issue by adding a trailing space to the sectionHeading (so ## Completed vs ## Completed).

I just released v0.1.11 with a fix for this issue. Can you check if you still seeing the duplicate logging on the latest version?

matpatterson commented 3 years ago

Updated to the latest version, and checked there is no whitespace after the section heading, but unfortunately it is still happening.

Screen Shot 2021-04-29 at 8 19 51 am
liamcain commented 3 years ago

🤦 Okay, I figured out the issue. I wasn't properly handling custom section headings. The latest version (0.1.12) should solve the real issue.

Sorry about that and thank you for your patience 🙏

matpatterson commented 3 years ago

Thanks for your work - I've updated to the latest but it is still duplicating for me. If you need other troubleshooting details from me, let me know.

I tried removing and re-adding the plugin just in case, but no improvement there.

liamcain commented 3 years ago

😢 That's very disappointing. I'm unable to reproduce the issue on my end. Could you send me the contents of your plugin settings file? It should be located at <Your Vault>/.obsidian/plugins/things-logbook/data.json

matpatterson commented 3 years ago

{"hasAcceptedDisclaimer":true,"latestSyncTime":1619666241,"isSyncEnabled":true,"syncInterval":1800,"sectionHeading":"## Completed","tagPrefix":"logbook/"}

matpatterson commented 3 years ago

I have a guess this is something to do with Obsidian syncing between my devices and the plugin settings not being the same everywhere, because I am now seeing the daily page update with both "Logbook" and "Completed" headings - three x Completed in a row, then one Logbook.

So maybe each device is doing its own update independently.

liamcain commented 3 years ago

I wasn't able to reproduce the issue with the settings configuration that you provided, but I hadn't considered that you were syncing from multiple devices.

I have a guess this is something to do with Obsidian syncing between my devices and the plugin settings not being the same everywhere, because I am now seeing the daily page update with both "Logbook" and "Completed" headings - three x Completed in a row, then one Logbook.

So maybe each device is doing its own update independently.

Aah, interesting. It's possible my initial hunch was right then and one of the device settings had a trailing space (so they didn't match exactly). Once all your devices have the same Section Heading, can you confirm whether or not the issue is resolved?

matpatterson commented 3 years ago

It's very strange - I have removed that plugin from the laptop, and closed Obsidian on that device too. So just the desktop has the plugin enabled now. The desktop I have changed to use ## Logbook

and yet, somehow it is still pulling out ## Completed...

Screen Shot 2021-05-04 at 9 42 23 am Screen Shot 2021-05-04 at 9 42 19 am