search

liamcottle / valorant.js

This is an unofficial NodeJS library for interacting with the VALORANT API used in game.
105 stars 19 forks source link

Fixes addFriend() #9

Closed Henrik-3 closed 3 years ago

Henrik-3 commented 3 years ago

Fixes the issues that addFriend() as an example always gives back status 200 and an empty data set

liamcottle commented 3 years ago

Any more info on what adding this does? I haven't tested the request, but you say:

Fixes the issues that addFriend() ... always gives back status 200 and an empty data set

What does it do instead?

Henrik-3 commented 3 years ago

Before the patch a request would give back always 200 code with no assitional data. Now it gives back the proper status code, as an example 409 when the user where you send a request too has the maximum requests reached or 404 when the user was not found. When the requestw as successful you get the puuid as an example back if you do a friend request and not an empty array anymore.

I think the rchat-blocking thing says the server to wait with a response until the promise on the server is ready