liamcurry / passport-steam

Steam (OpenID) authentication strategy for Passport and Node.js.
MIT License
349 stars 104 forks source link

Consider using certified OpenID library #121

Closed Officialstrike closed 1 year ago

Officialstrike commented 1 year ago

Currently, this library relies on the @passport-next/passport-openid(which hasn't been updated in 5 years) package, the package mentioned depends on the openid library on NPM, this package however is not certified by OpenID. Not relying on a certified library by OpenID might lead to security vulnerabilities; I strongly recommend that this library moves to a certified package or make upstream changes to minimize the risk. The certified packages are listed on their website: https://openid.net/certified-open-id-developer-tools/. As an example, they list the following:

node openid-client

welps commented 1 year ago

@Officialstrike This library is honestly not actively maintained by anyone, I'm happy to review and merge any contributions for the sake of this library, especially if they're security related, but I don't have permissions to bring in new people either

tobbbles commented 1 year ago

I also think given the state of the current library, maintainer contributions, lack of upstream support on current versions requiring a complete rewrite and thus a new major version; the best course of action is promote a successor to this library and officially mark this library as deprecated and only issuing security updates for a limited period of time.

From my current search I do not see another Steam Passport implementations, utilizing any newer libraries or standards that could be a spiritual successor.