search

liamcurry / passport-steam

Steam (OpenID) authentication strategy for Passport and Node.js.
MIT License
348 stars 104 forks source link

OpenID returns https, "Claimed identity is invalid" #80

Closed demipixel closed 6 years ago

demipixel commented 6 years ago

https://github.com/liamcurry/passport-steam/blob/08c56d79a95236b08353ace632352e6d755b9387/lib/passport-steam/strategy.js#L88-L92

I don't know why (everything worked fine before, maybe steam changed something?) but I'm getting https for the identifier. Does this mean it should be https:\/\/... or https?:\/\/...?

joshverd commented 6 years ago

Getting this exact error right now. I have found zero documentation on what this means, but I know something did change.

joshverd commented 6 years ago

Ok, it looks like there is an outstanding pull request that fixes this. Valve changed something with http/https requests on the API and it's tripping up the regex.

https://github.com/liamcurry/passport-steam/pull/74

OmarAssadi commented 6 years ago

Yeah, I haven't dug yet to figure out what actually changed. But, FWIW, everyone's integration is currently broken. It appears to go further than just the https change as I'm pretty sure we were already prepared for that in our own implementation.

demipixel commented 6 years ago

Are you sure? I changed it to support https and things seem to be working on my site... odd.

OmarAssadi commented 6 years ago

Really? Interesting. I'll have to double check again later. It may have coincidentally been down or something when I checked ours in the morning.

EDIT: Yeah, you're right. It was just the http -> https change.

tobbbles commented 6 years ago

Closed by https://github.com/liamcurry/passport-steam/pull/74.