Use DEL for backspace - Githubissues

liamg / darktile

:waning_crescent_moon: Darktile is a GPU rendered terminal emulator designed for tiling window managers.

MIT License

3.04k stars 113 forks source link

Use DEL for backspace #215

Closed mjs closed 5 years ago

mjs commented 5 years ago

Description

Use DEL (0x7F) instead of BS (0x08) for backspace/erase. This is the default for most Linux terminals (and works on Windows too).

See also:

Fixes #178

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Confirmed that backspace key works as expected with:

zsh on Linux using both my personal config which previous failed due to ^H binding
zsh on Linux using stock config (zsh -f)
bash on Linux using stock config
Windows with cmd.exe
Windows with powershell

Test Configuration:

OS: See above
Go version: 1.11.5

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

liamg commented 5 years ago

Not sure what happened with travis, reopened this here: https://github.com/liamg/aminal/pull/231