I have found aminal useful and hackable (since it is written in Go). However, I found the latency a bit too high when used Midnight Commander inside the terminal. So I have added a command line flag for optionally running the pprof profiler. This was not that useful as most time is spent in cgo calls, however, the option might be useful for future development.
Then I have added an option to set runtime.GOMAXPROCS(), and I have found than -threads 4 makes aminal responsive enough to be used with mc. I am aware that this is just ducktape and not a solution, but it certainly makes the terminal more usable, hence please merge it if you like the idea.
Best,
Botond
Fixes # (issue)
Type of change
Please delete options that are not relevant.
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update
Test Configuration:
OS: Linux penguin (ChromeOS container)
OS version: 4.19.113
Go version: go1.14
Checklist:
[X] My code follows the style guidelines of this project (gofmt)
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules
Pull Request Template
Description
Hello,
I have found aminal useful and hackable (since it is written in Go). However, I found the latency a bit too high when used Midnight Commander inside the terminal. So I have added a command line flag for optionally running the pprof profiler. This was not that useful as most time is spent in cgo calls, however, the option might be useful for future development. Then I have added an option to set
runtime.GOMAXPROCS()
, and I have found than-threads 4
makesaminal
responsive enough to be used withmc
. I am aware that this is just ducktape and not a solution, but it certainly makes the terminal more usable, hence please merge it if you like the idea.Best, Botond
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Test Configuration:
Checklist: