liamkf / Unreal_FASTBuild

Allows UnrealEngine to be built with FASTBuild for VS2015/VS2017 and Windows 10.
MIT License
180 stars 71 forks source link

Fix response file handling. #8

Closed samhocevar closed 5 years ago

samhocevar commented 8 years ago

Currently the response file handling for UE4.13 has two problems:

Unfortunately FASTBuild does not accept object lists as an action’s inputs, so this change will require applying the following patch to FASTBuild: https://github.com/fastbuild/fastbuild/pull/149

liamkf commented 8 years ago

Hmmmmmm yeah the Copy step is definitely a bodge, as I'm sure you've seen... :) if the exec and lib nodes supported the dependencies I'd love to get rid of it.

What you've done seems very reasonable as well!

If we wanted to avoid modifying FASTBuild could just calling something like File.SetLastWriteTimeUtc(ResponseFile, DateTime.UtcNow) on any response files we see for linker actions work? Then the Copy node would know it needs to run. I haven't spent much time on the latest with the response file silliness unfortunately...