search

liamks / libpytunes

Python Itunes Library parser
https://github.com/liamks/pyitunes
MIT License
220 stars 88 forks source link

Restore imports in module init #45

Closed shacker closed 7 years ago

shacker commented 7 years ago

My bad! Earlier I said that I couldn't see how or where the imports in init were used, and removed them. It turns out that I actually broke it by doing that, but the breakage was masked by particularities of my setup. The change made it so that you could no longer do:

from pyItunes import Library but had to do this instead: from pyItunes.Library import Library

which of course would break things for existing scripts out there that use this as a dependency.

Sorry! This PR restores the imports to the init.

NathanDotTo commented 7 years ago

Ah! my sanity is restored...

On 20 May 2017, at 18:56, Scot Hacker notifications@github.com wrote:

My bad! Earlier I said that I couldn't see how or where the imports in init were used, and removed them. It turns out that I actually broke it by doing that, but the breakage was masked by particularities of my setup. The change made it so that you could no longer do:

from pyItunes import Library but had to do this instead: from pyItunes.Library import Library

which of course would break things for existing scripts out there that use this as a dependency.

Sorry! This PR restores the imports to the init.

You can view, comment on, or merge this pull request online at:

https://github.com/liamks/pyitunes/pull/45

Commit Summary

Restore imports in module init File Changes

M pyItunes/init.py (3) Patch Links:

https://github.com/liamks/pyitunes/pull/45.patch https://github.com/liamks/pyitunes/pull/45.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

shacker commented 7 years ago

Sorry!

shacker commented 7 years ago

I would not generally merge my own PRs, but this one seemed critical.