search

liamrevell / Rphylip

An R interface for PHYLIP.
12 stars 12 forks source link

Add verbose argument to suppress all console progress #4

Open sckott opened 10 years ago

sckott commented 10 years ago

I see that you can pass quiet=FALSE or quiet=TRUE in function calls, but that doesn't suppress all console output. Can we add another parameter called e.g., verbose, or just change what quiet does so that we can suppress all console output?

This would be helpful for when people are using reproducible document and only want the actual object returned, e.g., a distance matrix, and not the console output to be put in their document.

liamrevell commented 10 years ago

Yes, that's a great idea. I think we should just change what quiet does, if that's easy. Can we just use invisible or capture.output around system, or is it more complicated than that.

liamrevell commented 10 years ago

I figured this out. I just need to add system(...,show.output.on.console=(!quiet)). I have not checked to make sure that this doesn't interfere with any of the normal operation of the fns. I will do that soon.

sckott commented 10 years ago

Great!