Closed zarvox closed 8 years ago
Resolved in 9eedf2d02f8e1e9017b574f482144c7cc27d1e00
Looks like it's still complaining about mismatched nullability:
Target Error
phabricator_user.user_mapper.phabricator_user_phid Wrong Nullable Setting
SCHEMATA ERRORS
The schemata have errors (detailed above) which the adjustment workflow can
not fix.
If you are not developing Phabricator itself, report this issue to the
upstream.
If you are developing Phabricator, these errors usually indicate that your
schema specifications do not agree with the schemata your code actually
builds.
If you intend for it to be definitely not null, then I think you drop the ? in https://github.com/liamzdenek/phabricator-sandstorm/commit/9eedf2d02f8e1e9017b574f482144c7cc27d1e00#diff-9bd11836aca3a1c70fb0bf0c58378047R15
Ooops, that's what i get for distracted coding. Fixed.
LiskDAO objects are expected to describe their expected schema, and rules on said schema.
UserMapper probably ought to specify at least a
self::CONFIG_COLUMN_SCHEMA
and aself::CONFIG_KEY_SCHEMA
so Phabricator won't complain about the unregistered columns:My glance over some schemas suggests that the user mapper migration should also make a few changes to be consistent with the other schemas:
phabricator_user_id
should be a varbinary(64) NOT NULL to refer to a PHID