lian / bitcoin-ruby

bitcoin utils and protocol in ruby.
Other
922 stars 322 forks source link

[Chore] Cleanup parse_data_from_io legacy/segwit parsing #222

Closed zquestz closed 6 years ago

zquestz commented 6 years ago

This just cleans up the parse_data_from_io method and makes it more readable.

I am new to this gem, so let me know if I messed anything up. ;)

etscrivner commented 6 years ago

LGTM

zquestz commented 6 years ago

Ok all tests are now passing. Fixed the issue.

Docs: https://bitcoin.org/en/developer-reference#raw-transaction-format https://github.com/bitcoin/bips/blob/master/bip-0144.mediawiki

lian commented 6 years ago

cherry-picked into master