search

liangfu / mxnet-mobilenet-v2

Reproduction of MobileNetV2 using MXNet
129 stars 20 forks source link

code comment is misleading #3

Open dwSun opened 6 years ago

dwSun commented 6 years ago

https://github.com/liangfu/mxnet-mobilenet-v2/blob/b3e26ca3ce1aff6e190d6e148b6fe778e11bc38f/symbols/mobilenetv2.py#L114

please fix this code， according to 1801.04381 v3.

misunderstood you code (T_T)

liangfu commented 6 years ago

The comment only shows size of input and output of an inverted residual block, and the tensor sizes that has been used internally inside the block are not illustrated in the comment. Take the line you highlighted for example, the input size for the block is 32x28x28, and an inverted residual block would use expansion layer to increase the tensor size to 192x28x28, then it would be reduced to 64x28x28 at output layer of the inverted residual block.

liangfu commented 6 years ago

I think the paper I got on my hand is the version that is published in January, there is a small mistake in the illustration of stride size. But when I look into the version that is published in April, it becomes more clear to me, the code comment is some what misleading. I would fix this as soon as possible. Thanks for reminding.