search

liangzan / contacts

A universal interface to import email contacts from various providers including Yahoo, Gmail, Hotmail, AOL, Plaxo, GMX.net, Web.de, inbox.it, sezname.cz.
BSD 3-Clause "New" or "Revised" License
23 stars 25 forks source link

GMX import not working any more, partially fixed #20

Open jensb opened 11 years ago

jensb commented 11 years ago

Since a couple days ago, GMX has redesigned most of its website and the redirects are not working any more. This is due to two reasons (both of which I have fixed locally):

  1. Mozilla Firefox 2.0 as user agent is not supported -> changing to Firefox 18 will work
  2. GMX uses relative redirects which base.rb does not support yet

The third reason is a change of redirects. I have fixed this, but it is currently not working, and I don't understand why, since when recording the session in Firefox the redirects and cookies are exactly the same.

Would you be willing to collaborate on a fix? I can send a patch with the current status.

liangzan commented 11 years ago

sure we can collaborate. i can give you commit rights if you want. otherwise i can contribute to your fork. but i think commit right are better isn't it?

jensb commented 11 years ago

Good idea. Commit rights will make sense when we have synchronized our trees. I have submitted a couple patches in my repo, but they don't fully work yet. Please have a look, maybe I'm missing something obvious. -> https://github.com/jensb/contacts/commits/master Once we get this working I can delete my tree (or keep it synched to yours) or we can work on the same repo. Thanks! Regards, Jens

liangzan commented 11 years ago

hi @jensb, you've been added as a collaborator. since you can commit, can i propose pushing your master as a feature branch on this repo? do let me know your rubygems account so i can let you have publish rights.