search

lianlab / gamekit

Automatically exported from code.google.com/p/gamekit
0 stars 0 forks source link

Some small compile errors in gkRayTest and gkCurve in r1232 #294

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Download the latest revision r1232   
2. Compile
3. Compile error on gkRayTest and gkCurve

What is the expected output? What do you see instead?
The expected output is that the program should compile without error
However, the compiler reports error on gkRayTest and gkCurve

What version of the product are you using? On what operating system?
r1232 on Windows 8 with Microsoft Visual Studio 2012

Please provide any additional information below.
The main error in gkRayTest is because

         GK_ASSERT(pScene)

should be

         GK_ASSERT(m_scene)
since r1220 remove pScene

The main error in gkCurve is because

         GK_ASSERT(m_light)

         GK_ASSERT(!m_light)

There seem no m_light in gkCurve so I just remove these two lines

Also, the correction to gkRayTest seem to not work with current runtime sample. 
I needed to change the name of the scene in the runtime sample from "scene" to 
"StartScene" to force gkRayTest to perform.

The attachment patch contains these corrections.

Thank you very much for providing these new features. They are great.

Sincerely,
Danil

Original issue reported on code.google.com by KAI.TING...@gmail.com on 3 Jan 2013 at 9:54

Attachments:

GoogleCodeExporter commented 9 years ago 
Thx for mentioning. I fixed the assert-related problems (these don't fire on 
linux, argh) but I couldn't reproduce the problem with momo_ogre.blend. Still 
working for me as intended.

Original comment by thomas.t...@googlemail.com on 4 Jan 2013 at 9:18

GoogleCodeExporter commented 9 years ago 
To dertom,

Thanks for applying the patch.

For the blender part, maybe I just missed something.

Thanks for the help.

Sincerely,
Danil

Original comment by KAI.TING...@gmail.com on 5 Jan 2013 at 2:58

GoogleCodeExporter commented 9 years ago 
Ok, as always thx to your help! 

Just for closing this issue, here the corresponding commits:
http://code.google.com/p/gamekit/source/detail?r=1234
http://code.google.com/p/gamekit/source/detail?r=1233

Original comment by thomas.t...@googlemail.com on 5 Jan 2013 at 3:19