search

liannesheppard / ENVH556_2021course

Course materials for UW ENVH 556 offered Winter 2021
Creative Commons Zero v1.0 Universal
3 stars 5 forks source link

different sizes and colors? #10

Closed slager closed 3 years ago

slager commented 3 years ago

I thought this graph was a little bit confusing -- having two different aesthetics with two different scales that are actually just saying the same thing. Is it better to just pick 1?

Note that PR #9 includes a fix to make it actually use log scale to generate colors, but this issue is about the broader question about whether to use both at all

https://github.com/liannesheppard/ENVH556_2021course/blob/d29fdef62f96fc058340388238ee8e236be48f1c/Week8LabGeostatistics.Rmd#L468

liannesheppard commented 3 years ago

I had the two different scales and then I decided it was confusing so I decided to drop the different scales and just show the native scale. Obviously I forgot to change the comment too. I'll probably go ahead and accept the commit (though I could as easily reject it) since I need to make at least one more change anyways.

slager commented 3 years ago

Ah, yeah, that makes sense.