search

lianqiw / maos

Multithreaded Adaptive Optics Simulator
https://github.com/lianqiw/maos/releases/
GNU General Public License v3.0
15 stars 3 forks source link

Adding Keck-specific pupil, ncpa maps, and vibration PSD. #9

Closed jluastro closed 1 year ago

jluastro commented 1 year ago

Just added some Keck-specific files, since I think they have to be in the repo to find them (unlike conf files). Let me know if you want me to add them to maos_keck instead and there is a way to set a path to find them.

lianqiw commented 1 year ago

It is also possible to specify a path= in some conf file and place these files there.

The amplitude and ncpa map seems to be transposed wrt each other. Did you check the simulation result?

jluastro commented 1 year ago

What do you mean “the amplitude”? I ran sims with just the ncpa map and just the pseudo-Kolmogorov random ncpa and both and they produce results as expected. Both is worse than one or none. I tracked the real-time output. Is there another output file I should examine?On May 23, 2023, at 6:34 AM, Lianqi Wang @.***> wrote: It is also possible to specify a path= in some conf file and place these files there. The amplitude and ncpa map seems to be transposed wrt each other. Did you check the simulation result?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

lianqiw commented 1 year ago

I plotted the two fits files in this pull request using ds9, the KECK_gaps_spiders.fits and Keck_ncpa_rmswfe115nm.fits. One seem to be transposed wrt another. The first file is what I call the amplitude map.

lianqiw commented 1 year ago

Can you transpose KECK_gaps_spiders.fits to agree with the NCPA, and rename it to KECK.fits and delete the existing KECK.bin?

jluastro commented 1 year ago

Fixed your suggestions above.

lianqiw commented 1 year ago

Thanks. Can you also edit examples/keck_base.conf to use KECK.fits rather KECK.bin so that the code is consistent.

jluastro commented 1 year ago

Oooh, yup. Forgot about that spot. Fixed now.

On May 25, 2023, at 11:22 AM, Lianqi Wang @.***> wrote:

Thanks. Can you also edit examples/keck_base.conf to use KECK.fits rather KECK.bin so that the code is consistent.

— Reply to this email directly, view it on GitHub https://github.com/lianqiw/maos/pull/9#issuecomment-1563521649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALEJQAHXBPK4D3RHDLYSRDXH7EQPANCNFSM6AAAAAAYLOX54Q. You are receiving this because you authored the thread.

=============================== Jessica Lu Associate Professor of Astronomy University of California, Berkeley @.***