search

liantze / AltaCV

Yet another alternative curriculum vitae/résumé class with LaTeX
Other
1.27k stars 331 forks source link

Create a github action that compiles the pdf #62

Closed badetitou closed 3 years ago

badetitou commented 3 years ago

These modifications add Github actions that compile and publish as release the last version of sample.tex as a file named "cv.pdf". It is thus possible to get the last version of the generated pdf at the URL: https://github.com/:owner/AltaCV/releases/download/latest/cv.pdf

badetitou commented 3 years ago

So,

I have detected a bug in my fork, and tried to understand where is the problem. It appears that my first PR was really bad (bibtex action does the latex+bibtex+latex+latex), and the latex actions were bad.

I have updated the latex action, so now it works, and it is faster (you can have a look at my fork in the main branch. I also have updated the .cls file because there is a bug with bib ion the last version. I only imply the quick fix proposed here: https://tex.stackexchange.com/questions/564990/error-after-miktex-reinstall-text-line-contains-an-invalid-character

liantze commented 3 years ago

Hello @badetitou, thanks for the contributions and discussions! Personally I would prefer this repo (i.e. my own) to contain LaTeX-only sources. I would strongly encourage that you host/fork these at your own repo.

liantze commented 3 years ago

@badetitou Please feel free to submit a separate PR for the pdfx/biblatex incompatibility if you wish; or I can update altacv.cls sometime soon.

rstm-sf commented 3 years ago

@liantze these changes help to determine early on that the submitted changes have broken something. So I don't understand why you give them up

liantze commented 3 years ago

@rstm-sf Thanks again for the discussion, and sorry about this. I will admit that it was purely due to my own preference that my own copy (the original anyway) of this repo contains only LaTeX-related code. Github actions, docker customisations are great extras! and I'm happy to see forks and customisations on these aspects by other users.

I suppose it is my own fault that I did not comment earlier on this PR (and other similar PRs) due to various other time-shortness/commitments in real life to react quickly on my own repos... I guess I should probably close/freeze my repos, at least until I have more time and energy on my hands.

rstm-sf commented 3 years ago

Ok, thanks for the answer ;)

badetitou commented 3 years ago

@liantze No problem, I'm already using the github action on my own repo (and use the generated link to the pdf in my personal website :) )

Thanks for your incredible work on this CV template!!

@rstm-sf Thanks for all your comments. I should spend more time on GitHub actions. I believe we can create super cool automated stuff.