liaojinxing / firepath

Automatically exported from code.google.com/p/firepath
GNU General Public License v3.0
0 stars 0 forks source link

Sizzle can overlap target window's Sizzle implementation #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The current approach to inserting Sizzle (which I submitted) can overlap the 
target window's Sizzle implementation.

I have attached a patch that fixes this.

The patch also adds:
No longer requires changes to sizzle.js so it's easy to drop in sizzle.js 
updates.
Moved the _firePathSizzle to sit on the wrapper rather than the target window 
(so its not visible to target window). 

Original issue reported on code.google.com by d...@studgeek.com on 29 Jul 2011 at 9:14

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks David! I just applied your patch with a few small changes at revision 
r42. It will be released in the next version of FirePath.

Original comment by pierre.t...@gmail.com on 6 Aug 2011 at 4:36

GoogleCodeExporter commented 9 years ago
Version 0.9.7 released on August 6th 2011

Original comment by pierre.t...@gmail.com on 14 Aug 2011 at 2:19