search

liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
243 stars 173 forks source link

Avanza Bank doesn't show everything #336

Closed ghost closed 9 years ago

ghost commented 9 years ago

I have both stocks (Aktier) and funds (Fonder) in my account on Avanza but it only shows my stocks. Before I bought the stocks It showed the funds. So there is something strange going on.

fredrike commented 9 years ago

Hej @larschanders,

I have a working patch that supports all types of founds (Stocks and Founds). I even added the title of what type we are looking at. Also, I added the "ProfitPercent" (both for the title's and each entry) but I'm not sure I like it in it's current form and layout.

Do you have any inputs before I submit the patch?

bankandroid

ghost commented 9 years ago

@fredrike Good job! To see both the percentages and the actual balance is really cool. Didn't expect that :)

fredrike commented 9 years ago

But are we not showing too much information?

I think it looks a bit cluttered.

ghost commented 9 years ago

Well, maybe a little. But I guess there's not much you can do regarding the GUI. It's pretty set in stone I presume? I rather have it "cluttered" than not showing perentages at all.

fredrike commented 9 years ago

I could use the currency field..

But that is perhaps even worse.

bankandroid1

goober commented 9 years ago

We are about to start the development of the next major version of Bankdroid with a whole new GUI. We need to consider how different account types should be displayed. See #305.

For the current GUI I suggest that you skip the percentage and only shows the amount (as it is today). I know that this is not perfect, but I think that it is the best approach right now.

fredrike commented 9 years ago

Ok fine, I'll wait with the percentage!

What is the coding standard, how should indentation be handled?

goober commented 9 years ago

I don't think that there is any outlined coding standard yet. This should also be something to be considered for #305

I suggest that you use 4 spaces indentation. And an empty line at thé end of each file.

fredrike commented 9 years ago

@larschanders I've played around a bit more with the avanza account, what do you think about this. Showing all different types of sub-accounts from the main view.

The account type is "OTHER" so the sub-accounts does not add up to the Bank total.

bankdroid

The type SEK is the "Saldo" or "Tillgängligt för köp".

What do you think?