search

liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
243 stars 173 forks source link

Shorten Amex card titles #564

Closed mhagander closed 8 years ago

mhagander commented 9 years ago

Many (most?) of the Amex card titles parsed from the site end up being very long, which makes the amount included in the notifications end up outside the screen.

Replace "American Express" with "Amex" and "EuroBonus" with "EB" in order to shorten these down, while keeping them unique and easy to identify.

fredrike commented 8 years ago

Why not include a newLine before "American Express" and "Amex" and "EuroBonus" instead?

mhagander commented 8 years ago

That would work equally well yeah. I don't think anybody would ever miss the "American Express" -> "AmEx" change (that's what everybody talks about anyway), but I guess that would make the EB part more clear.

I don't particularly care which way between those two :) So if that's preferred, I can create an updated patch that does that - or if you just want to adjust it at time of merge?

fredrike commented 8 years ago

You don't care to create a screen shot of both solutions and show here?

mhagander commented 8 years ago

I could certainly look into doing that. Before I venture down that route - is there a "known way" to trigger the notifications during testing, rather than just wait around for the next batch of transactions to hit and remember to run it then?

goober commented 8 years ago

Take a look at SettingsActivity.java#L126-L142

From the application you can then go into Settings -> Debug Settings -> Test Notification

mhagander commented 8 years ago

worked. However, I failed to actually get a newline into the notification - tried combinations of \n and \r, but they all go on a single line anyway :)

But to show examples of the current default vs the code in this PR:

s_2015-11-02-01-d33d23 s_2015-11-02-01-dbb57f

fredrike commented 8 years ago

Thank you!