liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
242 stars 173 forks source link

Should the two DataRetrieverTask classes be merged? #607

Closed walles closed 7 years ago

walles commented 7 years ago

This is more of a question than an actual issue, but here goes:

There are two DataRetrieverTask classes:

The first one is the one used when accounts are auto updated. It sometimes forgets to update the widget.

The second one looks quite similar but does seem to update the widget all the time.

Why two? Should they be merged? Can fish drown?

Regards /Johan

goober commented 7 years ago

I think @liato can answert this question, since he is the author of that particular part. However, from my point of view there is no reason to have them separated.

goober commented 7 years ago

and of course pull requests on this one is approved :)

walles commented 7 years ago

Nah, I did #608 instead. Never mind.