Fail build on Android Lint problems

liato / android-bankdroid

A swedish banking application for your Android device.

http://www.swedroid.se/forum/showthread.php?t=11108

Other

242 stars 173 forks source link

Fail build on Android Lint problems #627

Closed walles closed 7 years ago

walles commented 7 years ago

Fix one issue, disable lots of warnings to enable merging something at least.

walles commented 7 years ago

The actual removal of unused resources was done by:

Opening Android Studio
Doing Analyze / Run Inspection by Name
Choosing Unused resources
Whole project
Right clicking one of the errors
Clicking on the fix-automatically option

walles commented 7 years ago

Tested that Länsförsäkringar works after these removals.

goober commented 7 years ago

I see that all logos are included in this removal. Since bankdroid loads logo resources dynamically as seen in Bank.java#L387, it seems that the analysis does not recognize this usage. So maybe you can add an ignore pattern for the UnusedResource issue?

e.g. `

walles commented 7 years ago

Fixing UnusedResources seems too hard for now, this was easier.

Ready for re-review!

goober commented 7 years ago

I understand you :) but it is a good start! Thanks