liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
243 stars 173 forks source link

Use static Android resource loading everywhere #629

Closed walles closed 7 years ago

walles commented 7 years ago

This change replaces dynamic resource loading with static in all places I could find.

There are two points with this:

  1. It makes it obvious at compile time if a resource is missing.
  2. It makes it obvious to Android Lint which resources are actually unused and can be removed.

The Bank constructor now takes a logo ID parameter, and all banks supply it.

Logos have been moved into bankdroid-legacy, since that's the only place they are used from.

goober commented 7 years ago

Thanks for all your quality improvement work. It is much needed. And thanks @robho for your quick response.