liato / android-bankdroid

A swedish banking application for your Android device.

http://www.swedroid.se/forum/showthread.php?t=11108

Other

242 stars 173 forks source link

Android Lint: Enforce no unused resources #632

Closed walles closed 7 years ago

walles commented 7 years ago

Please review for unwanted resource removals...

walles commented 7 years ago

Thanks @robho, fixed!

goober commented 7 years ago

I need to checkout this PR and run it locally and do some regression testing before I can merge this. I hope it is ok.

walles commented 7 years ago

Sure!

My plan for this is that after this goes in I'll remove unused code, then remove unneeded Android Lint suppressions, then start to actually code on #610.

610 has UI work in it, and I want as much linter support as I can get for that...

walles commented 7 years ago

Also, I've found that the turnaround time for code reviews in here is amazing, and with sensible feedback, so big thanks @goober & @robho!

goober commented 7 years ago

I have done some testing and everything seems to work as expected. I will merge this.