liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
242 stars 173 forks source link

Fix all instances of e.printStackTrace() #636

Closed walles closed 7 years ago

walles commented 7 years ago

Not terribly important, but low hanging fruit now that Timber is in place.

Note for reviewers: I'm not sure we want all of those in Crashlytics, please consider that. But maybe too much data in Crashlytics is better than too little? In that case these should probably be dealt with on a case-by-case basis.

SEB.java wasn't used any more so I just removed the whole class.

goober commented 7 years ago

There are a lot of banks that have been deprecated since they now require Mobilt BankId. See LegacyBankFactory. I suggest that all those banks and related files are removed to clean up the code base. However, that should be the target for another PR.