search

liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
242 stars 173 forks source link

Fix Instant Run #644

Closed walles closed 7 years ago

walles commented 7 years ago

This change fixes Instant Run in Android Studio 2.2.1 by upgrading the Android Build Tools Gradle dependency (as suggested by Android Studio) and by not storing Contexts in static variables (as suggested by Android Lint).

walles commented 7 years ago

The failure is likely because of this bug: https://code.google.com/p/android/issues/detail?id=194092

walles commented 7 years ago

Nothing helps, bug reported here: https://code.google.com/p/android/issues/detail?id=225515

Closing for now, we'll see how that goes.

goober commented 7 years ago

I guess that you have already tried with adding the flag -Dlint.new-lib-model=true?

goober commented 7 years ago

I have tried to reproduce this locally as you suggested in the bug report, without any luck. The build succeeds locally

walles commented 7 years ago

Yeah, I did try -Dlint.new-lib-model=true, no luck :(.

Really strange that this works for you, wonder what you are (not) doing that I and Travis are?

For me this fails both locally and on Travis, same results.

goober commented 7 years ago

I had an old gradle daemon running. When I ran will the --no-daemon flag it failed for me as well

walles commented 7 years ago

However much I dislike saying this, as long as UnusedResources doesn't work we can't use it :/.

Disabling warning and squashing, please review.

goober commented 7 years ago

I agree with you that the proper solution is to temporary disable the UnusedResources for now. And the update-supressions.sh script will catch when the bug if fixed (if we do not introduce more unused resources)