search

liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
243 stars 173 forks source link

Fix whitespace issues #663

Closed walles closed 7 years ago

walles commented 7 years ago

Enable Checkstyle whitespace checks.

Ran into some violations in an earlier PR, found it was bad for readability.

fredrike commented 7 years ago

Great! But I think the removed files should be in a separate pr.

@goober what is the purpose of the removed files?

goober commented 7 years ago

@fredrike I agree with you that the removed files should be a separate PR. However, I would like them to be kept for a while. I have an upcoming PR that uses some of the classes so please keep them for now. I will do a cleanup as soon as I am finished.

walles commented 7 years ago

I removed the files as a way to resolve whitespace errors in them; since they were unused fixing them seemed not worth any effort.

But since I need to rebase anyway I'll just put them back as part of that rebase.

goober commented 7 years ago

It looks good. However, it would be great if you could leave LegacyBankHelper as well.