liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
242 stars 173 forks source link

If asked for an unknown bank, log the id #668

Closed walles closed 7 years ago

walles commented 7 years ago

So instead of getting in Crashlytics... BankType id not found. ... we now get... BankType id not found: 1234

This way it will be easier to understand why we get these exceptions and how they should be handled (or not).

goober commented 7 years ago

We get them since we have just removed a lot of banks that we support. However, we did not make sure that the saved banks were deleted from the db. So a proper solution is to remove all saved banks that has an id that is not found in IBankTypes

walles commented 7 years ago

Agreed, but this would tell us which banks have been left behind.

Not a big deal though, feel free to close or merge.

goober commented 7 years ago

Just wanted to give you a little background on why we get the error :) Of course I'll merge it!