search

liato / android-bankdroid

A swedish banking application for your Android device.
http://www.swedroid.se/forum/showthread.php?t=11108
Other
243 stars 173 forks source link

PMD: Enforce variable naming #671

Closed walles closed 7 years ago

walles commented 7 years ago

Inspired by: https://github.com/liato/android-bankdroid/pull/667/files/0513e7c0b45b748b342ebb61026ee18f5cfc5322#r86446572

Naming conventions violations are better found by tooling.

Non-final fields with NAMING_INDICATING_FINALITY have been turned into final fields when possible.

In Bank.java, refactored the API a bit so that bank names can be constant.

Unit tests pass, and I've tested adding Länsförsäkringar as a bank and checking my accounts, and that still works.

goober commented 7 years ago

Great! Good work. I hope your IDE helped you with this change :)

walles commented 7 years ago

It did.

I started doing it in Atom, then I shortly switched to IntelliJ...