liatrio / liatrio-otel-collector

The Liatrio distribution of the OpenTelemetry Collector
https://openo11y.dev
Apache License 2.0
35 stars 4 forks source link

Fix the release of the otel collector to enable importing by version of module packages #408

Closed adrielp closed 2 weeks ago

adrielp commented 4 months ago

Overview

To build a custom collector from outside of the Liatrio OTEL Collector means you have to import the package with a version specified like v0.0.0-<hash>. This is because the version of the package internally doesn't get edited with the release on main.

The OpenTelemetry release cycle is a bi-weekly cycle where releases are cut from an external repository which edits the files according to the new release version.

We should fix this such that:

jburns24 commented 1 month ago

Talked about this issue with Adriel from a high level my understanding is the task is to modify the release workflow on merge to main such that it

  1. calculates the next semvar
  2. runs multimod with the next semvar
  3. commits the changed files (with a chore tag)
  4. run goreleaser to build and publish

Adriel posted a bunch of helpful links here

gnmeyer commented 4 weeks ago

457

adrielp commented 3 weeks ago

So was able to get multimod to work after some troubleshooting. There's still some issues though that have to be fixed.

  1. pkg.go.dev doesn't detect the version because semantic release cuts against originating version, and doesn't include the commits made in the workflow.
  2. Some slowness around the pipeline. Implemented a caching PR but it's actually slower. There's some potential restructuring we can do to make things a little faster.

Happy to sync up on this. I thought there was another thing but I did sleep over the weekend so not recalling right now.

jburns24 commented 3 weeks ago

Current issue is that go-semantic-release tagged the sha that triggered the workflow instead of the commit made my multimod

I think the path forward is:

From this conversation

jburns24 commented 3 weeks ago

Once we validate in pkg.go.dev is updated and 'build-and-test- does not run twice in a row let's call this done.

adrielp commented 3 weeks ago

TODO: (can be done under a separate ticket)

After changes & iterations, pkg.go.dev and things now correctly work.

jburns24 commented 2 weeks ago

Changelog refinement done in #477