implement gh actions workflow

lib / pq

Pure Go Postgres driver for database/sql

https://pkg.go.dev/github.com/lib/pq

MIT License

8.89k stars 906 forks source link

implement gh actions workflow #1054

Closed michaelshobbs closed 2 years ago

michaelshobbs commented 2 years ago

ref: https://github.com/lib/pq/pull/1047#issuecomment-906062580

the TestSSLClientCertificates fails on postgres 13 & 12 with ssl_test.go:269: remote error: tls: bad certificate but the other postgres versions seem to work.

EDIT: also TestSSLVerifyFull fails on golang 1.17 with ssl_test.go:104: x509: certificate relies on legacy Common Name field, use SANs instead. From what I can tell, they removed the GODEBUG=x509ignoreCN=0 flag.

michaelshobbs commented 2 years ago

@otan @mjibson I'm not an SSL expert by any stretch so any pointers here would be great

otan commented 2 years ago

i'm no expert either, but my guess is those certificates have to be regenerated. maybe worth following https://www.postgresql.org/docs/current/ssl-tcp.html.

this is looking awesome btw!

michaelshobbs commented 2 years ago

@otan @mjibson i believe this is good to go now

michaelshobbs commented 2 years ago

once this is merged, i'll update #1047 with these commits

otan commented 2 years ago

this is awesome, cheers buddy