Bad connection error after commit fails due to statement_timeout

[horgh]

Hello!

I have been periodically seeing these errors in my application:

driver: bad connection

I investigated today and I found strange behaviour in this situation:

• I am in a transaction
• I have statement_timeout set to something non-zero
• The commit or rollback call hits the statement_timeout condition
• Afterwards, pinging (or maybe using the connection at all?) raises a bad connection error

I'm wondering if this is what should be happening given there is an error message available showing that the transaction failed.

Here is a program that demonstrates this: https://play.golang.org/p/fYi3vNb3p7L

If you run this for a while (e.g. while [ true ]; do ./foo ; done), you will periodically see messages like this:

error committing: pq: canceling statement due to statement timeout
error pinging after commit failure: driver: bad connection

I am using lib/pq v1.2.0, Postgres 9.6.15, and Go 1.13.4.

What do you think?

Thank you!