libAtoms / ExtXYZ.jl

Extended XYZ read/write support for Julia
MIT License
13 stars 6 forks source link

Rename properties in AtomsBase Interface #24

Closed JanHab closed 1 year ago

JanHab commented 2 years ago

Hello, i wonder why you didn't use the AtomsBase names for the properties in atom_data and system_data. Wouldn't it be good to rename "box" to "bounding_box", "positions" to "position", "atomic_symbols" to "atomic_symbol", and so on. I just tried it with a few of these properties and for those i've tried it, it seems to work.

Are the names you used important for something or would it be possible to change them, and if so, would you welcome to have this names changed @jameskermode?

jameskermode commented 2 years ago

Happy to change these names to match AtomsBase. These near misses are just an oversight, since the ExtXYZ default names are quite different (Lattice for box, pos for positions etc).

mfherbst commented 1 year ago

This has been done in #29