Closed fekad closed 5 years ago
indeed, I like your proposal. let’s return the count, and demand “-yes"
On 29 May 2019, at 17:54, Adam Fekete notifications@github.com wrote:
Similarly, we need to be able to delete, like: abcd delete -q
Do you think we should make this command return the count (or other summary) of the stuff to be deleted, and tell the user to add "-yes" to the command line to actually do the deletion, or is that only for babies ?
Originally posted by @gabor1 in #18 (comment)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
-- Gábor
Gábor Csányi Professor of Molecular Modelling Engineering Laboratory Pembroke College University of Cambridge
Pembroke College supports CARA. A Lifeline to Academics at Risk. http://www.cara.ngo/
If there is no query string this command (of course only if the --yes has been used) will destroy the whole database :)
Maybe we should catch this case and refuse to do it? Perhaps we should use a separate subcommand to delete everything from the database (without deleting the database itself, ie it is still possible to put things in it afterwards)
-- Gábor
On 29 May 2019, at 19:31, Adam Fekete notifications@github.com wrote:
If there is no query string this command (of course only if the --yes has been used) will destroy the whole database :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Similarly, we need to be able to delete, like: abcd delete -q
Do you think we should make this command return the count (or other summary) of the stuff to be deleted, and tell the user to add "-yes" to the command line to actually do the deletion, or is that only for babies ?
Originally posted by @gabor1 in https://github.com/libAtoms/abcd/issues/18#issuecomment-479890529