libAtoms / abcd

2 stars 4 forks source link

add option to ignore case in key names #66

Open jameskermode opened 5 years ago

jameskermode commented 5 years ago

I uploaded a file containing some properties named DFT_force and others named dft_force. I know I can rename them with abcd rename-key, but since in ASE and QUIP case is ignored for property names it would be good to have an option to do this in abcd. Maybe this should even be the default?

fekad commented 5 years ago

This can only work if never two store keys which only differ in their case. Would that be ok?

jameskermode commented 5 years ago

I think this would be ok, yes. Maybe start with a non-default option to ignore case and see how it goes?

fekad commented 4 years ago

It woud be nice if we stored properties in case sensitive mode, but optionally allowed the user to search case insensitively. for this to work, I have to find out if Mongo supports case insensitive searches. if it doesn't then we can decide to either not have this option or to actually store everything in lower case.

fekad commented 4 years ago

As far as I know, MongoDB doesn't have any option to ignore the cases for the keys:

There is a way to create case insensitive indices but not for the

fekad commented 4 years ago

Any decision about this?

fekad commented 4 years ago

Decision: default to the lower casing keywords with a command-line option to not do it. + pre-check @ upload