search

libAtoms / extxyz

Extended XYZ specification and parsers
MIT License
16 stars 4 forks source link

Fix parsing of floats that run together in a backward compatible array #7

Closed bernstei closed 3 years ago

bernstei commented 3 years ago

Fix end of float regexp to prevent 0.05.44 from being parsed as 0.05 followed by .44 in a backward compatible array of floats (since Repeat doesn't require separation between Regex elements) . Add corresponding test.

closes #6

max-veit commented 3 years ago

https://vimeo.com/77647572#t=210s - possible test case?

bernstei commented 3 years ago

https://vimeo.com/77647572#t=210s - possible test case?

I'm surprised I had never seen that before, although I suspect Gabor has.

gabor1 commented 3 years ago

Indeed I have. Many times.

-- Gábor

Gábor Csányi Professor of Molecular Modelling Engineering Laboratory, University of Cambridge Pembroke College Cambridge

Pembroke College supports CARA. A Lifeline to Academics at Risk. http://www.cara.ngo/

On 26 Aug 2021, at 16:39, bernstei @.***> wrote:

https://vimeo.com/77647572#t=210s - possible test case?

I'm surprised I had never seen that before, although I suspect Gabor has.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

bernstei commented 3 years ago

@jameskermode any reason not to merge?

jameskermode commented 3 years ago

nope, let's do it.