search

libAtoms / matscipy

Materials science with Python at the atomic-scale
http://libatoms.github.io/matscipy/
GNU Lesser General Public License v2.1
188 stars 55 forks source link

fail to install from github in github CI #148

Closed bernstei closed 1 year ago

bernstei commented 1 year ago

I'm trying to set up a github CI that uses matscipy, and attempting to install using from the github repo fails, e.g. https://github.com/libAtoms/pymatnext/actions/runs/4779137831/jobs/8496016926

I'm going to try to reproduce outside the github CI.

pastewka commented 1 year ago

Looks like we need to add pure: false to the meson build file.

bernstei commented 1 year ago

If you try that, please post here and I'll trigger another run of the CI action in my repo that uses it.

I guess on general principle it would be nice to be able to pip install from the repo, but out of curiosity, would you expect that it'd work for me if I just installed the pypi release instead of straight from github?

bernstei commented 1 year ago

BTW, the reason I'm using the github HEAD is that there's an issue with a deprecated/unsupported use of np.str in eam.io, and the pypi version doesn't work, so tagging a new version would actually solve my immediate problem as well.

pastewka commented 1 year ago

Hi @bernstei - can you try out the 23_pure_builds branch, see PR here: https://github.com/libAtoms/matscipy/pull/149

pastewka commented 1 year ago

@bernstei - the change has been merged into master

bernstei commented 1 year ago

@bernstei - the change has been merged into master

Thanks - I'll try another CI installation, and see if it fixes the issue.

bernstei commented 1 year ago

matscipy from github installation in the CI works fine now. Thanks for the quick fix.

bernstei commented 1 year ago

fixed by #149 or #150, apparently.