Closed pgrigorev closed 1 year ago
Looks good, thanks @pgrigorev. I'll be happy to merge anyway, but I left a couple of optional comments for you to consider.
The cirrus CI failures should be fixed by #149 and #150. Please rebase/merge from main into this branch to confirm this before we merge this PR.
Thank you very much for such a quick response! I will happily rebase and take into account other comments.
Thanks!
The main enhancement is the addition of 1/2<110>{111} edge and screw dislocations in FCC. In FCC these dislocations dissociate into two 1/6<112>{111} Shockley partials as for example: 1/2[1-10] = 1/6<2-1-1> + ISF + 1/6<1-21>. The implementation includes:
FCCScrewShockleyPartial
- Shockley screw partialFCCScrew110Dislocation
- dissociated <110> screw dislocationFCCEdgeShockleyPartial
- Shockley edge partialFCCEdge110Dislocation
- dissociated <110> edge dislocationI also added relevant test and fixed few bugs.
CubicCrystalDissociatedDislocation
was significantly reworked. Now it checks that provided partials have same properties and the sum of the burgers vectors results in the desired value. After that the properties of the resulting dislocation are taken from one of the partials. It makes the code more readable and robust.