search

libAtoms / matscipy

Materials science with Python at the atomic-scale
http://libatoms.github.io/matscipy/
GNU Lesser General Public License v2.1
188 stars 55 forks source link

scipy.optimize.NoConvergence no longer exists #156

Closed prs513rosewood closed 1 year ago

prs513rosewood commented 1 year ago

Corrected the use of the scipy.optimize.NoConvergence exception, which is no longer part of scipy.optimize.

pastewka commented 1 year ago

Has it moved to a different location in scipy? I can't really imagine them removing it completely.

prs513rosewood commented 1 year ago

It can be imported from scipy.optimize.nonlin but that module is deprecated. It's defined in scipy.optimize._nonlin. It might be an oversight on their part, but since it's only used in one place in matscipy I thought I'd replace it altogether

pastewka commented 1 year ago

Okay, sounds good.