libAtoms / matscipy

Materials science with Python at the atomic-scale
http://libatoms.github.io/matscipy/
GNU Lesser General Public License v2.1
188 stars 55 forks source link

[JOSS Review] Reproducibility and functionality #184

Closed mbarzegary closed 10 months ago

mbarzegary commented 1 year ago

Dear authors,

Generally speaking, the software runs more or less as described in the documentation. However, there are some comments in this regard:

P.S. This issue is related to https://github.com/openjournals/joss-reviews/issues/5668

jotelha commented 10 months ago

https://github.com/libAtoms/matscipy/pull/192 resolved bullet point 4.

Addressing bullet point 3 for the electrochemistry submodule examples: Within https://github.com/libAtoms/matscipy/pull/210, I have turned the electrochemistry example notebooks into proper documentation and consequently removed them from the not very neatly curated examples/electrochemistry folder. This folder now only contains sample bash scripts for a simple parametric studies with the electrochemistry CLI.