Closed mbarzegary closed 10 months ago
https://github.com/libAtoms/matscipy/pull/192 resolved bullet point 4.
Addressing bullet point 3 for the electrochemistry submodule examples: Within https://github.com/libAtoms/matscipy/pull/210, I have turned the electrochemistry example notebooks into proper documentation and consequently removed them from the not very neatly curated examples/electrochemistry
folder. This folder now only contains sample bash scripts for a simple parametric studies with the electrochemistry CLI.
Dear authors,
Generally speaking, the software runs more or less as described in the documentation. However, there are some comments in this regard:
samples_pb_c2d.py
andsamples_pnp_c2d.py
examples results in the following error:ModuleNotFoundError: No module named 'matscipy.electrochemistry.utility'
. The error forsamples_pnp_by_fenics_fem.py
is related to lack ofmatscipy.electrochemistry.poisson_nernst_planck_solver_fenics
module.P.S. This issue is related to https://github.com/openjournals/joss-reviews/issues/5668