Part of the electrochemistry module does not follow coding style

libAtoms / matscipy

Materials science with Python at the atomic-scale

http://libatoms.github.io/matscipy/

GNU Lesser General Public License v2.1

188 stars 55 forks source link

Part of the electrochemistry module does not follow coding style #216

Closed pastewka closed 10 months ago

pastewka commented 10 months ago

We adhere to PEP-8, which mentions "Function names should be lowercase, with words separated by underscores as necessary to improve readability." Part of the electrochemisty module uses CamelCase.

Example: https://github.com/libAtoms/matscipy/blob/ba2179106680a102d4510d2be1bdf8374c3be645/matscipy/electrochemistry/poisson_nernst_planck_solver.py#L382

pastewka commented 10 months ago

@jotelha - can you have a look at this?

jotelha commented 10 months ago

Addressed in https://github.com/libAtoms/matscipy/pull/218