search

libAtoms / matscipy

Materials science with Python at the atomic-scale
http://libatoms.github.io/matscipy/
GNU Lesser General Public License v2.1
188 stars 55 forks source link

NGLView visualisations are broken in the published documentation #261

Closed pgrigorev closed 4 months ago

pgrigorev commented 4 months ago

The current version of published documentation shows JavaScript error in the place on NGLView visualisations.

[Open Browser Console for more detailed log - Double click to close this message]
Failed to load model class 'NGLModel' from module 'nglview-js-widgets'
ReferenceError: s is not defined
    at Object. (https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:12109:4412)
    at __webpack_require__ (https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:20:30)
    at Object. (https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:69164:11)
    at __webpack_require__ (https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:20:30)
    at Object. (https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:69141:18)
    at __webpack_require__ (https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:20:30)
    at https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:63:18
    at https://cdn.jsdelivr.net/npm/nglview-js-widgets@3.1.0/dist/index.js:66:10
    at Object.execCb (https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.min.js:1:12861)
    at b.check (https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.min.js:1:6577)

I am not sure if that is similar to what was happening before. I can also see a lot of warnings (>1000) in the build log of the docs.

pgrigorev commented 4 months ago

At the end it is the same issue as #222 it is just that the version was changed by this sneaky commit from renovate[bot]. I will prepare a MR to fix it.

pastewka commented 4 months ago

Fixed by #262