Closed stenczelt closed 1 month ago
I really have no idea what to do with this. I've never used poetry. Do we need to publish expyre and universal-SOAPS in pypi (in which case we might as well do workflow itself as well), so we don't have to do git+https
?
[edited] we could use https://github.com/marketplace/actions/pypi-publish, which seems easy enough. I guess we could do it only on specific (release) tags, but we'd have to get in the habit of creating them.
Also, I found this https://python-poetry.org/docs/dependency-specification/#git-dependencies
Well, publishing on pypi
would surely make things simpler and I can highly support that! My suspicion is that the setup.py
's definitions of dependencies are not understood by poetry:
https://github.com/libAtoms/workflow/blob/69bbae2f7bc01aa59327016f1ba6cbfe42c9f2e5/setup.py#L7-L9
If we can get someone to adopt the exporting to pypi task, I can help, but don't have time to do it myself. We can discuss on the slack.
For now, do you want to try replacing the the https://github.com/libAtoms/ExPyRe/tarball/main
with git+https://github.com/libAtoms/ExPyRe.git
, and so on for universalSOAP? Maybe it'd be happier with that syntax.
@stenczelt do you want to look at this again? Some combination of pypi and going to pyproject.toml
might have fixed it.
I've tried it again now, and it's working. Thanks!
The package cannot be installed with
poetry
usinggit+...
due to git-only dependencies.When running
I am getting
I've tried with Python 3.9 as well, no difference.
How to reproduce
Create a
pyproject.toml
file with the following minimal content (or usepoetry init
)