search

libMesh / TIMPI

Templated Interface to MPI
GNU Lesser General Public License v2.1
12 stars 11 forks source link

Better fixes for Packing specializations #95

Closed roystgnr closed 2 years ago

roystgnr commented 2 years ago

My earlier fixes for strings broke sufficiently-long non-strings.

The new tests here cover this bug; I'm also going to run some test privately to see if I can trigger any downstream regressions and to ensure that the fix here also works for the sort of bug that we saw originally.

roystgnr commented 2 years ago

No, this isn't quite there. I'll take a crack at the remaining issues tomorrow.

moosebuild commented 2 years ago

Job Coverage on 520babd wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

roystgnr commented 2 years ago

This seems to be working for me downstream too now.