libMesh / libmesh

libMesh github repository
http://libmesh.github.io
GNU Lesser General Public License v2.1
659 stars 286 forks source link

Fixes for NetCDF 4.6.2 tests run with HDF > 1.12 #4000

Closed jwpeterson closed 2 weeks ago

jwpeterson commented 2 weeks ago

This is a patch by @ostueker which he developed on the 1.7.x release branch. I tested it there (albeit only with older HDF) and it worked fine, so it should probably also be on the 1.8.x branch as well as master.

ostueker commented 2 weeks ago

This patch is based on Unidata/netcdf-c#1671 and was adapted so that it can be applied to libmesh/contrib/netcdf/netcdf-c-4.6.2.

moosebuild commented 2 weeks ago

Job Test with threads on c66cdc8 : invalidated by @jwpeterson

Unrelated occasional failure seen in metaphysicl unit testing

moosebuild commented 2 weeks ago

Job Coverage, step Generate coverage on c66cdc8 wanted to post the following:

Coverage

d2f82b #4000 c66cdc
Total Total +/- New
Rate 62.37% 62.37% -0.00% -
Hits 72655 72652 -3 0
Misses 43839 43842 +3 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.