Removed SDL2MAIN_LIBRARY from the list of requred vars.

libSDL2pp / libSDL2pp

C++ bindings/wrapper for SDL2

https://sdl2pp.amdmi3.ru

Other

564 stars 89 forks source link

Removed SDL2MAIN_LIBRARY from the list of requred vars. #124

Closed whoozle closed 6 years ago

whoozle commented 6 years ago

Fedora's SDL2 rpm package is lacking main library, and it looks like SDL is not using this approach anymore, and it can be safely ignored

AMDmi3 commented 6 years ago

I doubt SDL can drop this approach - while it's indeed not necessary for *nix systems, it's required for other systems which have entry points different from int main(). Without libSDLmain, client code will need to have #ifdef for each supported system.

Can we maybe stay on a safe side and leave it required on non-unix systems, e.g. leave the current behavior under IF(NOT UNIX)?

whoozle commented 6 years ago

yes, sure, I've wrapped this in IF (UNIX), please take a look. It could find main library on gentoo, but no main lib in SDL2/SDL2-devel packages in Fedora unfortunately.

AMDmi3 commented 6 years ago

Thank you!