dumb project is archived

liballeg / allegro5

The official Allegro 5 git repository. Pull requests welcome!

https://liballeg.org

Other

1.9k stars 285 forks source link

dumb project is archived #1550

Closed chenrui333 closed 6 months ago

chenrui333 commented 7 months ago

👋 just a heads up that dumb project has been unmaintained for quite some time and now it is archived.

relates to https://github.com/Homebrew/homebrew-core/pull/168144

pedro-w commented 7 months ago

... i.e the DUMB project!

It's still an optional dependency of acodec. The original DUMB on sourceforge has not been touched since 2014 . The kode54 fork here on github (which is the one homebrew draws from) has not been updated for 6 years and has now been archived by kode54. I think the options are

drop DUMB entirely
Find an actively maintained fork, or fork it from kode54 into a new repo which we would maintain
incorporate the source directly in acodec
update acodec to use libopenmpt which (I don't know anything about it) is the replacement suggested by kode54.

SiegeLord commented 7 months ago

libopenmpt seems like the best choice, imo. It seems impractical to add more things to maintain.

SiegeLord commented 7 months ago

Broad outline:

Rename modaudio.c to dumb.c, but otherwise keep it (why not?)
Add openmpt.c, based on modaudio.c, being careful to match the bizzare looping logic we have

I don't expect this to be too hard, if libopenmpt is any good.

chenrui333 commented 7 months ago

... i.e the DUMB project!

you are absolutely correct! :) Just updated the title 👍

pedro-w commented 7 months ago

I don't expect this to be too hard

"The rest is mere coding" 😀

SiegeLord commented 7 months ago

https://github.com/liballeg/allegro5/pull/1551 is my initial attempt, basic playback etc is supported, but internal looping points are not handled correctly yet

ReiquelApplegate commented 7 months ago

I was trying to remove the nonnull-before-free checks from DUMB, which is not necessary to do in the C language, but kode45 just archived the project. I can fork DUMB and refactor that so there's less code to maintain if anyone wants.

SiegeLord commented 7 months ago

If someone were to take over DUMB maintainership, that would be convenient as it's still a reasonably functional library. It can't be us, however.

ReiquelApplegate commented 7 months ago

You can pencil me in as the maintainer.

pedro-w commented 7 months ago

If you could take it on, that would be great. Also if you could contact homebrew and macports as they are currently pointing to the archived 'upstream' and the original SourceForge repo, respectively!

SiegeLord commented 7 months ago

Here's some suggestions:

Contact kode54, get control over the repository
Create a DUMB org, transfer kode54's repository to the new org
Next time this happens, new people can be added to the org, rather than passing the repo around

SiegeLord commented 6 months ago

Now that I added OpenMPT support, there is now a workaround. I have reason to believe DUMB provides superior rendering quality, but OpenMPT seems decent enough to be used when DUMB is unavailable for some reason.